Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve viewport scrolling #24

Merged
merged 5 commits into from
Apr 18, 2018
Merged

feat: improve viewport scrolling #24

merged 5 commits into from
Apr 18, 2018

Conversation

ktsn
Copy link
Owner

@ktsn ktsn commented Apr 17, 2018

fix #20

This is an initial implementation to deal with Photoshop-like viewport scrolling.

If the viewport is enough smaller than the window size, it does not allow scroll, otherwise the wrapper element of viewport will have much larger size than window so that we can scroll it in larger area.

Maybe I will refactor the code since the code is a bit messy.

@ktsn
Copy link
Owner Author

ktsn commented Apr 17, 2018

viewport-scroll

@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #24 into master will increase coverage by 0.92%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage    64.2%   65.13%   +0.92%     
==========================================
  Files          44       44              
  Lines        1369     1394      +25     
  Branches      315      317       +2     
==========================================
+ Hits          879      908      +29     
+ Misses        475      471       -4     
  Partials       15       15
Impacted Files Coverage Δ
src/view/components/Renderer.vue 96.42% <96%> (+96.42%) ⬆️
src/view/components/Viewport.vue 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73c909...228d17a. Read the comment docs.

@ktsn ktsn merged commit b99f861 into master Apr 18, 2018
@ktsn ktsn deleted the improve-scroll branch April 18, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Photoshop-like viewport scrolling
1 participant