Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve assets in preview #31

Merged
merged 6 commits into from
May 5, 2018
Merged

feat: resolve assets in preview #31

merged 6 commits into from
May 5, 2018

Conversation

ktsn
Copy link
Owner

@ktsn ktsn commented May 3, 2018

This is naive implementation that handling assets. The user can preview assets (images) which are specified on src attribute on <img> elements.

I will also support url(...) function in style blocks.

@ktsn ktsn changed the title [WIP] feat: preview asset in preview [WIP] feat: resolve assets in preview May 3, 2018
@codecov
Copy link

codecov bot commented May 5, 2018

Codecov Report

Merging #31 into master will increase coverage by <.01%.
The diff coverage is 52.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   64.47%   64.48%   +<.01%     
==========================================
  Files          44       45       +1     
  Lines        1430     1481      +51     
  Branches      331      334       +3     
==========================================
+ Hits          922      955      +33     
- Misses        493      512      +19     
+ Partials       15       14       -1
Impacted Files Coverage Δ
src/message/bus.ts 0% <0%> (ø) ⬆️
src/vue-designer.ts 0% <0%> (ø) ⬆️
src/parser/vue-file.ts 0% <0%> (ø) ⬆️
src/server/main.ts 0% <0%> (ø) ⬆️
src/asset-resolver.ts 100% <100%> (ø)
src/parser/template/manipulate.ts 97.29% <100%> (+0.52%) ⬆️
src/parser/style/manipulate.ts 100% <100%> (+9.52%) ⬆️
src/utils.ts 87.5% <80%> (-1.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8611d...7d2fda4. Read the comment docs.

@ktsn ktsn changed the title [WIP] feat: resolve assets in preview feat: resolve assets in preview May 5, 2018
@ktsn ktsn merged commit 668450c into master May 5, 2018
@ktsn ktsn deleted the asset-support branch May 5, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant