Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to modify props and data in preview pane #32

Merged
merged 6 commits into from
May 21, 2018
Merged

Conversation

ktsn
Copy link
Owner

@ktsn ktsn commented May 10, 2018

No description provided.

@codecov
Copy link

codecov bot commented May 10, 2018

Codecov Report

Merging #32 into master will decrease coverage by 1.16%.
The diff coverage is 41.26%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #32      +/-   ##
=========================================
- Coverage   65.27%   64.1%   -1.17%     
=========================================
  Files          44      46       +2     
  Lines        1480    1535      +55     
  Branches      355     368      +13     
=========================================
+ Hits          966     984      +18     
- Misses        500     537      +37     
  Partials       14      14
Impacted Files Coverage Δ
src/view/components/PageMain.vue 0% <ø> (ø) ⬆️
src/view/components/Renderer.vue 79.48% <ø> (ø) ⬆️
src/view/components/ScopeInformation.vue 0% <0%> (ø)
src/view/components/InputJson.vue 0% <0%> (ø)
src/view/components/ComponentCatalogPreview.vue 0% <0%> (ø) ⬆️
src/view/components/ContainerVueComponent.vue 100% <100%> (ø) ⬆️
src/view/components/VueComponent.vue 88.88% <100%> (ø) ⬆️
src/view/store/modules/project.ts 48.04% <51.51%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1380f22...da9cb1c. Read the comment docs.

@ktsn ktsn changed the title [WIP] feat: allow to modify props and data in preview pane feat: allow to modify props and data in preview pane May 21, 2018
@ktsn
Copy link
Owner Author

ktsn commented May 21, 2018

The implementation may be messy and the <InputJson> is not user friendly but it just works.
I will refactor / improve them later.

@ktsn ktsn merged commit d4442d2 into master May 21, 2018
@ktsn ktsn deleted the props-data-edit branch May 21, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant