feat: allow to include shared styles #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 66.31% 64.46% -1.86%
==========================================
Files 50 51 +1
Lines 1633 1683 +50
Branches 378 390 +12
==========================================
+ Hits 1083 1085 +2
- Misses 535 583 +48
Partials 15 15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR let us to specify
vueDesigner.sharedStylesconfig which allows to include global styles into the preview page.It would be useful when we use some css frameworks, reset / normalize css or so on.
I guess I will update this PR to enable watching the changes for the shared styles so that update the preview style in realtime.
Currently, shared style affects globally not only user defined components but also app level (Vue Designer's) components. It should be avoided but seems the implementation will be a bit complicated. I would leave it as a further improvement.
The preprocessors are not supported as same as
<style>block in SFC.