Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render slot contents #43

Merged
merged 6 commits into from
Jul 1, 2018
Merged

feat: render slot contents #43

merged 6 commits into from
Jul 1, 2018

Conversation

ktsn
Copy link
Owner

@ktsn ktsn commented Jul 1, 2018

Vue Designer renders slot contents after this PR. Scoped slots are not supported yet.

As the further work, we need to edit slot content of previewing component so that we can confirm how it looks like in preview pane as same as props / data.

@codecov
Copy link

codecov bot commented Jul 1, 2018

Codecov Report

Merging #43 into master will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   64.27%   64.65%   +0.37%     
==========================================
  Files          51       52       +1     
  Lines        1688     1706      +18     
  Branches      384      390       +6     
==========================================
+ Hits         1085     1103      +18     
  Misses        588      588              
  Partials       15       15
Impacted Files Coverage Δ
src/view/components/VueComponent.vue 88.88% <ø> (ø) ⬆️
src/view/components/ContainerNode.vue 77.77% <ø> (ø) ⬆️
src/view/components/ContainerVueComponent.vue 100% <100%> (ø) ⬆️
src/view/components/Node.vue 52.17% <100%> (+4.55%) ⬆️
src/view/components/Child.vue 83.33% <100%> (+5.55%) ⬆️
src/view/components/NodeSlot.vue 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04bcabc...b4e66a8. Read the comment docs.

@ktsn ktsn merged commit c5a398d into master Jul 1, 2018
@ktsn ktsn deleted the slot-support branch July 1, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant