Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support updating style declaration in preview #6

Merged
merged 12 commits into from
Mar 14, 2018
Merged

Conversation

ktsn
Copy link
Owner

@ktsn ktsn commented Mar 12, 2018

This feature allows us to edit styles in the preview pane like chrome devtools but it immediately update the original code in SFC.

I'll add more test and support renaming declaration prop later.

Adding declaration is not supported yet.
editable-style

@codecov-io
Copy link

codecov-io commented Mar 12, 2018

Codecov Report

Merging #6 into master will increase coverage by 0.51%.
The diff coverage is 69.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   63.65%   64.17%   +0.51%     
==========================================
  Files          34       36       +2     
  Lines        1175     1242      +67     
  Branches      283      298      +15     
==========================================
+ Hits          748      797      +49     
- Misses        414      432      +18     
  Partials       13       13
Impacted Files Coverage Δ
src/parser/style/codegen.ts 88.88% <ø> (ø) ⬆️
src/view/components/PageMain.vue 0% <ø> (ø) ⬆️
src/message/bus.ts 0% <0%> (ø) ⬆️
src/view/components/StyleInformation.vue 0% <0%> (ø) ⬆️
src/parser/vue-file.ts 0% <0%> (ø) ⬆️
src/server/main.ts 0% <0%> (ø) ⬆️
src/parser/style/manipulate.ts 90% <100%> (+8.18%) ⬆️
src/parser/style/transform.ts 83.52% <100%> (ø) ⬆️
src/view/components/StyleValue.vue 100% <100%> (ø)
src/parser/modifier.ts 92.7% <100%> (+0.31%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e4158...8e963b7. Read the comment docs.

@ktsn ktsn changed the title [WIP] feat: support updating style declaration in preview feat: support updating style declaration in preview Mar 14, 2018
@ktsn ktsn merged commit 50e56d3 into master Mar 14, 2018
@ktsn ktsn deleted the editable-style branch March 14, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants