Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid applying props / data when compositing #66

Merged
merged 1 commit into from
Oct 27, 2018

Conversation

ktsn
Copy link
Owner

@ktsn ktsn commented Oct 27, 2018

fix #53

@codecov
Copy link

codecov bot commented Oct 27, 2018

Codecov Report

Merging #66 into master will increase coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   67.84%   67.87%   +0.03%     
==========================================
  Files          60       61       +1     
  Lines        2071     2092      +21     
  Branches      425      428       +3     
==========================================
+ Hits         1405     1420      +15     
- Misses        647      653       +6     
  Partials       19       19
Impacted Files Coverage Δ
src/view/components/InputComposition.vue 100% <100%> (ø)
src/view/components/InputJson.vue 83.33% <14.28%> (-8.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1243180...38b78ed. Read the comment docs.

@ktsn ktsn merged commit f5f6d50 into master Oct 27, 2018
@ktsn ktsn deleted the consider-composition branch October 27, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid saving prop value by pressing enter during composition
1 participant