Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: focus next item when the user finished to edit style value #71

Merged
merged 3 commits into from
Nov 24, 2018

Conversation

ktsn
Copy link
Owner

@ktsn ktsn commented Nov 24, 2018

ref #13

By this PR, the focus on style input form will move the next item when the user finishes to edit it by pressing enter or tab key.

@ktsn ktsn mentioned this pull request Nov 24, 2018
6 tasks
@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #71 into master will increase coverage by 0.61%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   67.42%   68.04%   +0.61%     
==========================================
  Files          66       66              
  Lines        2229     2244      +15     
  Branches      455      461       +6     
==========================================
+ Hits         1503     1527      +24     
+ Misses        706      697       -9     
  Partials       20       20
Impacted Files Coverage Δ
src/view/components/StyleValue.vue 46.66% <100%> (+2.8%) ⬆️
src/view/components/StyleDeclaration.vue 93.33% <66.66%> (-6.67%) ⬇️
src/view/components/StyleInformation.vue 65.62% <85.71%> (+65.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f33c62...396ae13. Read the comment docs.

@ktsn ktsn merged commit 9709305 into master Nov 24, 2018
@ktsn ktsn deleted the move-focus-style-editing branch November 24, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant