Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Juman++v2 to C++11 #20

Closed
eiennohito opened this issue Jul 22, 2017 · 3 comments
Closed

Backport Juman++v2 to C++11 #20

eiennohito opened this issue Jul 22, 2017 · 3 comments
Labels
help wanted

Comments

@eiennohito
Copy link
Contributor

eiennohito commented Jul 22, 2017 •
edited
Loading

Remove C++14 specific parts or at least make them conditionally go away when compiled in C++11 mode.
Most of C++14 features used now are constexpr in StringPiece.
Need also to fix CMake configuration.
@eiennohito eiennohito added the v2 label Jul 22, 2017
@eiennohito eiennohito added help wanted and removed v2 labels Nov 28, 2017
@DoumanAsh DoumanAsh mentioned this issue Jan 4, 2018
Closed
@eiennohito eiennohito mentioned this issue May 3, 2018
Closed
@versusvoid
Copy link

And why exactly is it needed?

@eiennohito
Copy link
Contributor Author

eiennohito commented Jan 7, 2019 •
edited
Loading

Not really, I think (because I found out that RHEL has wonderful toolkits).
The codebase is mostly C++11 with an exception of 1 or 2 places though.

@eiennohito
Copy link
Contributor Author

I thought that there would be problems on RHEL-based distros regarding C++14, but there seems to be none. Let's be C++14 and forward until the further notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eiennohito @versusvoid