max zip entries

[dsula]

Hi,

I discovered that the maximum number of entries in a zip file is 65535.
Any chance that this limitation could be increased?

Cheers
ds

[dsula]

Browsing thru zip.c I see code like that:

// no zip64 support yet
if ((pzip->m_total_files == 0xFFFF)

Is > 64k entries considered zip64 support?

Cheers

[kuba--]

@dsula - kind of.. (some zip64 extensions support more than 64K entries):

The original .ZIP format had a 4 GiB (232 bytes) limit on various things (uncompressed size of a > file, compressed size of a file, and total size of the archive), as well as a limit of 65,535 (2^16) > entries in a ZIP archive.

[zhu-ty]

I am also reaching this point, I have total >4GiB files in one zip file, how did you fix it? @dsula

[dsula]

@zhu-ty : I had no other choice but to split the zip into multiple files. Then I built a container file combining the multiple zip files into one. It worked for me because I don't have to handle individual files out of the zip archive. It's either compress them all or extract them all.

[kuba--]

I'll try to fix it, adding an extra support, so I'm reopening the issue (so far)

[zhu-ty]

OH, @kuba-- and @dsula thanks a lot for your help! Then maybe I will just wait for your solution~

[zhu-ty]

Well is the problem fixed?

[kuba--]

@zhu-ty - not yet. I'll have to upgrade miniz.h (carefully) which already supports 64bit zips.

[kuba--]

It turned out that to solve this issue in a solid way we need to add support for zip64.
I spent a day to upgrade miniz (which already supports zip64), but it's kind of tricky, mainly because our fork hacked it a little bit, plus zip.c also contains some parts of miniz implementation.
Anyway, tests started failing, so I've reverted my work. Hopefully we can fix/add support for zip64 in something like v2.0.0. But for v2 I suppose we should not modify miniz, and in zip.c use only miniz API. The only open question is... can we achieve all what we have so far (merging etc.) just with pure miniz interface.

[dsula]

that was quick. Nice Job!

[kuba--]

@dsula - I'm closing the issue, right now. I'll open a new one just to add zip64 support.
So far the issue still exists, because the library does not support zip64, yet.

[dsula]

Ok, gotcha.

[kuba--]

https://github.com/kuba--/zip/issues/109

[zhu-ty]

That was quick thanks, I will be watching the new issue