New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid client.revoke() call #120
Comments
@jeaye, this is fixed on my fork: https://github.com/zenhack/simp_le This repository seems to be abandoned; @kuba has been inactive on Github since June of last year. The reason parameter was introduced in python-acme 0.11, which was released some time after this repo was abandoned. |
On Sat, Apr 22, 2017 at 12:27:08PM -0700, Ian Denhardt wrote:
@jeaye, this is fixed on my fork:
<https://github.com/zenhack/simp_le>
This repository seems to be abandoned; @kuba has been inactive on Github since June of last year. The reason parameter was introduced in python-acme 0.11, which was released some time after this repo was abandoned.
Yep, I've found that, thanks. The issue is that NixOS is currently pointing at 0.1.1 of your fork (which still has this issue), not 0.2.0: https://github.com/mayflower/nixpkgs/blob/master/pkgs/tools/admin/simp_le/default.nix I'm currently testing out 0.2.0 before making a PR/issue in nixpkgs.
Thanks again.
|
Worth noting, 0.1.1 specifies an upper bound on the version of python-acme, specifically because of compatibility issues like this; If you're hitting this issue it's because you're using incompatible versions. |
On Sat, Apr 22, 2017 at 12:31:57PM -0700, Ian Denhardt wrote:
Worth noting, 0.1.1 specifies an upper bound on the version of python-acme, specifically because of compatibility issues like this; If you're hitting this issue it's because you're using incompatible versions.
Yep, I think that's because someone did this: https://github.com/mayflower/nixpkgs/blob/master/pkgs/tools/admin/simp_le/default.nix#L15
Grr.
|
I really wish distro packagers would report (perceived) bugs like this upstream more reliably... Grr indeed. |
It looks like we're only passing the cert to
client.revoke
, but it also expects a reason. The current simp_le version:https://github.com/kuba/simp_le/blob/master/simp_le.py#L1331
The official docs:
http://letsencrypt.readthedocs.io/projects/acme/en/latest/api/client.html#acme.client.Client.revoke
This is manifesting, for me, when trying to revoke a cert:
The text was updated successfully, but these errors were encountered: