Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support stop_grace_period and stop_signal #224

Open
jbrekelmans opened this issue Jun 30, 2019 · 0 comments
Open

support stop_grace_period and stop_signal #224

jbrekelmans opened this issue Jun 30, 2019 · 0 comments

Comments

@jbrekelmans
Copy link
Collaborator

jbrekelmans commented Jun 30, 2019

Kubernetes does not have an API to configure the signal sent to containers on shutdown, but docker-compose and Dockerfiles do. STOPSIGNAL in a Dockerfile is respected by Kubernetes, but stop_signal in docker-compose is not
stop_grace_period should be mapped to terminationGracePeriod.
We should give a warning if stop_signal in specified and not set to SIGTERM.

How are stop signals parsed?
https://github.com/moby/moby/blob/e105a74c54193e0ebdeddd93afc8746c33aeca73/container/container.go#L498
stop timeout vs stop_grace_period?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant