Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter watched secret to only kube-green managed ones #434

Open
davidebianchi opened this issue May 19, 2024 · 2 comments
Open

Filter watched secret to only kube-green managed ones #434

davidebianchi opened this issue May 19, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@davidebianchi
Copy link
Member

The code watches all the secrets of the cluster. So, When the controller starts, it consumes a lot of memory and cpu.

The solution is to set some custom labels on secrets managed by kube-green and watch only these secrets.

Originally posted by @blezoray in #271 (comment)

@davidebianchi davidebianchi added bug Something isn't working enhancement New feature or request labels May 19, 2024
@makinjc
Copy link

makinjc commented Jun 3, 2024

We hit this as well, bumped up to memory to 6G for the time being. Out of curiosity, why the design choice is to store previous values are on secrets but not as annotations on the objects itself?

@davidebianchi
Copy link
Member Author

Hi @makinjc! The choice was done in order to reduce the amount of changes made to the original manifest. Additionally, other informations are also needed, so there was a need to create a secret to maintain the state anyway.

@davidebianchi davidebianchi added this to the v0.6.0 milestone Jun 8, 2024
@davidebianchi davidebianchi removed this from the v0.6.0 milestone Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants