Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lock ttl from the kured defaults #1182

Closed
valkenburg-prevue-ch opened this issue Jan 22, 2024 · 1 comment
Closed

Remove lock ttl from the kured defaults #1182

valkenburg-prevue-ch opened this issue Jan 22, 2024 · 1 comment

Comments

@valkenburg-prevue-ch
Copy link
Contributor

https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/blame/8cb5c3e3054530da6f4d4af640d2200b6eb701bc/locals.tf#L624

IMHO this is a regression: the ttl makes the lock expire when a node is cordoned and fails to complete the reboot cycle. As a consequence, it is possible the one by one many nodes become unavailable, practically taking down the cluster. I had to understand this the hard way. I would prefer the default being what it was before, no lock expiration. We could expand the comment about kured_options in kube.tf.example maybe?

@mysticaltech
Copy link
Collaborator

Merged, will do a release later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants