Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Condition from k8s-openapi crate for condition #28

Closed
aryan9600 opened this issue Feb 26, 2024 · 0 comments · Fixed by #30
Closed

Use Condition from k8s-openapi crate for condition #28

aryan9600 opened this issue Feb 26, 2024 · 0 comments · Fixed by #30
Labels
area/maintenance enhancement New feature or request help wanted Extra attention is needed

Comments

@aryan9600
Copy link
Contributor

aryan9600 commented Feb 26, 2024 •
edited
Loading

We seem to be generating our own Condition definition for each API. While this is fine, I think it'd be better if we could use the Condition API from the k8s-openapi crate (https://docs.rs/k8s-openapi/latest/k8s_openapi/apimachinery/pkg/apis/meta/v1/struct.Condition.html).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/maintenance enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use standard Condition definitions and add a Default derive aryan9600/gateway-api-rs
2 participants
@shaneutt @aryan9600