review + be slightly more resilient without the opt-in

basically special-case the empty params case with an internal is_default
(cannot do Eq/PartialEq because upstream types do not have it).

which does mean delete_collection with default delete params keeps on
working on 1.25 (but then immediately breaks if they change from default
without the evar)

Signed-off-by: clux <sszynrae@gmail.com>

.github/workflows/ci.yml

@@ -156,7 +156,8 @@ jobs:
         run: cargo build
 
       # Run the equivalent of `just integration`
-      - run: cargo test --lib --all -- --ignored
+      - name: Run all default features integration library tests
+        run: cargo test --lib --all -- --ignored
       - name: Run all facade integration library tests with extra features
         run: cargo test -p kube --lib --features=derive,runtime -- --ignored --nocapture
       - name: Run crd example tests

kube-core/src/params.rs

@@ -476,6 +476,13 @@ impl DeleteParams {
         self.preconditions = Some(preconditions);
         self
     }
+
+    pub(crate) fn is_default(&self) -> bool {
+        !self.dry_run
+            && self.grace_period_seconds.is_none()
+            && self.propagation_policy.is_none()
+            && self.preconditions.is_none()
+    }
 }
 
 // dryRun serialization differ when used as body parameters and query strings:

kube-core/src/request.rs

@@ -149,7 +149,9 @@ impl Request {
         }
         let urlstr = qp.finish();
 
-        let data = if std::env::var("KUBE_UNSTABLE_V1_25_DELETE").is_ok() {
+        let data = if dp.is_default() {
+            vec![] // default serialize needs to be empty body
+        } else if std::env::var("KUBE_UNSTABLE_V1_25_DELETE").is_ok() {
             // Empty delete params triggers an error in kubernetes v1.25
             // https://github.com/kubernetes/kubernetes/issues/111985