Replace make as a script running with just
#903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To follow conventions used in rest of org. Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 70.35% 70.37% +0.02%
==========================================
Files 62 62
Lines 4291 4291
==========================================
+ Hits 3019 3020 +1
+ Misses 1272 1271 -1
|
Signed-off-by: clux <sszynrae@gmail.com>
|
Perhaps add |
Signed-off-by: clux <sszynrae@gmail.com>
|
Have added it to the devcontainer. The third party tools are currently documented on https://kube.rs/tools/ which sits under the contributing section. Do you think that's OK? |
Signed-off-by: clux <sszynrae@gmail.com>
kazk
reviewed
May 10, 2022
kazk
reviewed
May 10, 2022
kazk
approved these changes
May 10, 2022
Co-authored-by: kazk <kazk.dev@gmail.com>
Co-authored-by: kazk <kazk.dev@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
kazk
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow conventions used in rest of org.
..triggered by needing to make a new target and stopped writing make pretty much everywhere else.