Avoid special Config::incluster behavior for rustls
#1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clux <sszynrae@gmail.com>
clux
changed the title
Config::incluster behavior for rustlsConfig::incluster behavior for rustls
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
==========================================
+ Coverage 73.48% 73.49% +0.01%
==========================================
Files 68 68
Lines 5355 5354 -1
==========================================
Hits 3935 3935
+ Misses 1420 1419 -1
|
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Closed
kazk
approved these changes
Apr 5, 2023
clux
added a commit
to kube-rs/version-rs
that referenced
this pull request
Apr 5, 2023
last sanity check for kube-rs/kube#1184 Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
rustlsto not have speculative override behaviour since it should work in all cases after #1183 and linked changes.Closes #1003 plus #1109 (the last open
rustlsissues)