Check HTTP status code in request_stream

[chubei]

Would you like to work on this feature?

yes

What problem are you trying to solve?

The request_stream function doesn't call handle_api_errors as other functions. User can't easily tell whether the returned HTTP body is for an error response or successful response.

Describe the solution you'd like

In request_stream, check the response code. If it's an error, fetch the whole HTTP body, parse the error and return Err.

Describe alternatives you've considered

Include the headers in the returned Ok variant of request_stream.

Documentation, Adoption, Migration Strategy

No response

Target crate for feature

kube-client

[clux]

Thanks for this. Yeah, this looks wrong to me as well.

Note that the Api::log_stream is a relatively new in its current form; it was updated in #1235 to use use AsyncRead.

We should at the very least get the status (as you say) and bubble up an error here, but i'm unsure if we can just take the body and try to parse it as an ErrorResponse as we do in general in the handle_api_errors fn. Experimentation here would be very much welcome. I'm a bit busy the next coming weeks, so have to leave this open.

[chubei]

I can work on this if you find the solution acceptable.

[clux]

Yeah, it seems reasonable to me. Thanks a lot!

[clux]

Fixed in #1433