Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Version Dependencies #1362

Closed
rakshith-ravi opened this issue Nov 30, 2023 · 1 comment · Fixed by #1435
Closed

Refactoring Version Dependencies #1362

rakshith-ravi opened this issue Nov 30, 2023 · 1 comment · Fixed by #1435

Comments

@rakshith-ravi
Copy link

Opening an issue as per the discussion on discord: https://discord.com/channels/500028886025895936/1179918831917994005

I was just going through the dependencies and I wanted to propose an alternate way to handle dependencies:

  • All deps will be declared on the workspace level, with default-features = false. No deps will be declared in individual crates.
  • Each individual crate can opt-in for a dependency (by just doing workspace = true.
  • All versions are declared on a workspace level and will be inherited by the sub-crates.

Motivation

This way, if we ever want to update a dependency, we have a single file (the workspace Cargo.toml file) where all the versions can be updated and all sub-crates get the same exact version. No worries about mismatch or anything else. We can even use this for path based deps. Makes things easier. This is how I do it in my repos, and they're a breeze to manage.

If that's not the direction you'd want the project to go in, that perfectly works fine too.

@clux clux linked a pull request Mar 25, 2024 that will close this issue
@clux
Copy link
Member

clux commented Mar 25, 2024

This is now-done in main via #1435

@clux clux closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants