disable unused futures feature
#1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tottoto <tottotodev@gmail.com>
tottoto
force-pushed
the
disable-unused-futures-feature
branch
from
80c8950
to
b01bb35
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
=====================================
Coverage 72.1% 72.1%
=====================================
Files 78 78
Lines 6594 6594
=====================================
Hits 4749 4749
Misses 1845 1845 |
clux
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
LGTM. Thanks!
Nice to kill the executor feature and most of futures-util.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
futurescrate's features seem not to be used.