Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Body::empty for easier tests #1444

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Expose Body::empty for easier tests #1444

merged 2 commits into from
Mar 26, 2024

Conversation

clux
Copy link
Member

@clux clux commented Mar 26, 2024

minor ergonomic improvement over Body::from(Bytes::new()). mock tests generally have to import the Body anyway

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux linked an issue Mar 26, 2024 that may be closed by this pull request
@clux clux added the changelog-add changelog added category for prs label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.1%. Comparing base (362b985) to head (223ec1e).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1444   +/-   ##
=====================================
  Coverage   72.1%   72.1%           
=====================================
  Files         78      78           
  Lines       6594    6594           
=====================================
  Hits        4749    4749           
  Misses      1845    1845           
Files Coverage Δ
kube-client/src/client/body.rs 87.9% <100.0%> (ø)

@clux clux added changelog-fix changelog fix category for prs and removed changelog-add changelog added category for prs labels Mar 26, 2024
@clux clux marked this pull request as ready for review March 26, 2024 17:10
@clux clux merged commit acc347e into main Mar 26, 2024
18 checks passed
@clux clux deleted the expose-body-empty branch March 26, 2024 17:18
@clux clux added this to the 0.90.0 milestone Mar 26, 2024
@clux clux mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube::client::Body::empty() is private and cannot be used in unit tests
2 participants