Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace chrono feature clock with now #1448

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Mar 27, 2024

Seems to be able to use a subset of clock feature, now which is introduced at 0.4.32.

https://github.com/chronotope/chrono/releases/tag/v0.4.32

Signed-off-by: tottoto <tottotodev@gmail.com>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.1%. Comparing base (0952c2a) to head (d6d022b).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1448   +/-   ##
=====================================
  Coverage   72.1%   72.1%           
=====================================
  Files         78      78           
  Lines       6594    6594           
=====================================
  Hits        4749    4749           
  Misses      1845    1845           

@clux clux added the changelog-fix changelog fix category for prs label Mar 28, 2024
@clux clux added this to the 0.90.0 milestone Mar 28, 2024
Copy link
Contributor

@mateiidavid mateiidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a look at the diff (chronotope/chrono#1343), removes the overhead of adding timezone support.

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible, now seems to bring in only alloc and alloc seems to gate what we use (timestamp formatting generally)

@clux clux merged commit ff5a9e4 into kube-rs:main Mar 28, 2024
17 checks passed
@tottoto tottoto deleted the chrono-now branch March 28, 2024 12:06
@clux clux mentioned this pull request Apr 2, 2024
@clux clux changed the title replace chrono feature clock with now replace chrono feature clock with now Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants