Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor converting body to data stream #1453

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Mar 31, 2024

Refactors converting body to its data stream.

Signed-off-by: tottoto <tottotodev@gmail.com>
@tottoto tottoto force-pushed the refactor-converting-body-to-data-stream branch from a019950 to 569106a Compare March 31, 2024 16:19
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.1%. Comparing base (02c99f2) to head (569106a).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1453     +/-   ##
=======================================
+ Coverage   72.1%   72.1%   +0.1%     
=======================================
  Files         78      78             
  Lines       6604    6601      -3     
=======================================
- Hits        4756    4755      -1     
+ Misses      1848    1846      -2     
Files Coverage Δ
kube-client/src/client/body.rs 83.8% <100.0%> (ø)
kube-client/src/client/mod.rs 74.4% <40.0%> (+0.7%) ⬆️

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup. thank you!

@clux clux added this to the 0.90.0 milestone Mar 31, 2024
@clux clux added the changelog-exclude changelog excluded prs label Mar 31, 2024
@clux clux merged commit 49ef112 into kube-rs:main Mar 31, 2024
17 checks passed
@tottoto tottoto deleted the refactor-converting-body-to-data-stream branch March 31, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants