Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove BodyDataStream #1455

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Apr 1, 2024

Removes BodyDataStream.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.1%. Comparing base (156a6e6) to head (8cf014f).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1455     +/-   ##
=======================================
- Coverage   72.1%   72.1%   -0.0%     
=======================================
  Files         78      78             
  Lines       6601    6591     -10     
=======================================
- Hits        4755    4747      -8     
+ Misses      1846    1844      -2     
Files Coverage Δ
kube-client/src/client/body.rs 84.9% <100.0%> (+1.2%) ⬆️
kube-client/src/client/mod.rs 74.4% <100.0%> (ø)

Signed-off-by: tottoto <tottotodev@gmail.com>
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice use of upstream types (TryFilter docs and BodyStream)

@clux clux added this to the 0.90.0 milestone Apr 1, 2024
@clux clux added the changelog-exclude changelog excluded prs label Apr 1, 2024
@clux clux merged commit 05d115b into kube-rs:main Apr 1, 2024
17 checks passed
@tottoto tottoto deleted the remove-body-data-stream branch April 1, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants