[e2e] Ensure the latest version is selected before submitting (#1827)

* Only request chartVersion if not populated Co-authored-by: absoludity <absoludity@gmail.com>
vmware-tanzu · Jul 2, 2020 · 0be157d · 0be157d
1 parent 2bfcb3a
commit 0be157d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/dashboard/src/components/DeploymentFormBody/DeploymentFormBody.tsx b/dashboard/src/components/DeploymentFormBody/DeploymentFormBody.tsx
@@ -53,8 +53,12 @@ class DeploymentFormBody extends React.Component<
   };
 
   public componentDidMount() {
-    const { chartID, chartNamespace, getChartVersion, chartVersion } = this.props;
-    getChartVersion(chartNamespace, chartID, chartVersion);
+    const { chartID, chartNamespace, getChartVersion, chartVersion, selected } = this.props;
+    const { version } = selected;
+    if (!version || version.id !== chartID) {
+      // The chart version may have been already populated from the ChartView
+      getChartVersion(chartNamespace, chartID, chartVersion);
+    }
   }
 
   public componentDidUpdate = (prevProps: IDeploymentFormBodyProps) => {

diff --git a/integration/use-cases/create-private-registry.js b/integration/use-cases/create-private-registry.js
@@ -94,6 +94,10 @@ test("Creates a private registry", async () => {
 
   await expect(page).toSelect("#chartVersion", "7.3.16");
 
+  await expect(page).toClick("li", { text: "Changes" });
+
+  await expect(page).toMatch("tag: 2.4.43-debian-10-r54");
+
   await expect(page).toClick(".button-primary");
 
   await expect(page).toMatch("Up to date", { timeout: 60000 });