Adding eslint (#1888)

dashboard/package.json

@@ -92,12 +92,15 @@
     "lint-js-fix": "tslint -c ./tslint.ci.json --fix 'src/**/*.{ts,tsx}'",
     "lint-css": "stylelint --config ./.stylelintrc.json 'src/**/*.scss'",
     "lint-css-fix": "stylelint --config ./.stylelintrc.json --fix 'src/**/*.scss'",
-    "lint": "npm-run-all lint-js lint-css",
+    "eslint": "eslint '**/*.{ts,tsx}' --ignore-pattern '**/*.d.ts' --max-warnings=0",
+    "eslint-fix": "eslint '**/*.{ts,tsx}' --ignore-pattern '**/*.d.ts' --fix --max-warnings=0",
+    "lint": "npm-run-all lint-js lint-css eslint",
     "ts-compile-check": "tsc -p tsconfig.json --noEmit"
   },
   "lint-staged": {
     "*.{ts,tsx}": [
       "yarn run lint-js-fix",
+      "yarn run eslint-fix",
       "prettier --write",
       "git add"
     ],

dashboard/src/components/AppView/AccessURLTable/AccessURLTable.v2.tsx

@@ -119,7 +119,7 @@ export default function AccessURLTable({ ingressRefs, serviceRefs }: IAccessURLT
     // Fetch all related Ingress resources. We don't need to fetch Services as
     // they are expected to be watched by the ServiceTable.
     ingressRefs.forEach(r => dispatch(actions.kube.getResource(r)));
-  }, [ingressRefs]);
+  }, [dispatch, ingressRefs]);
   const ingresses = useSelector((state: IStoreState) =>
     flattenResources(ingressRefs, state.kube.items),
   ) as Array<IKubeItem<IResource>>;

dashboard/src/components/DeploymentFormBody/BasicDeploymentForm/BasicDeploymentForm.test.tsx

@@ -35,7 +35,7 @@ const defaultProps = {
     params: [
       {
         path: "configuration",
-        value: "First line\n" + "Second line",
+        value: "First line\nSecond line",
         render: "textArea",
       } as IBasicFormParam,
     ],
@@ -118,7 +118,7 @@ const defaultProps = {
     );
     expect(wrapper).toMatchSnapshot();
 
-    t.params.map((param, i) => {
+    t.params.forEach((param, i) => {
       wrapper.find(`input#${param.path}-${i}`).simulate("change");
       const mockCalls = handleBasicFormParamChange.mock.calls;
       expect(mockCalls[i]).toEqual([param]);

dashboard/src/components/DeploymentFormBody/BasicDeploymentForm/TextParam.test.tsx

@@ -60,7 +60,7 @@ it("should set the input value as empty if a string parameter value is not defin
 
 const textAreaParam = {
   path: "configuration",
-  value: "First line\n" + "Second line",
+  value: "First line\nSecond line",
   type: "string",
 } as IBasicFormParam;
 const textAreaProps = {
@@ -92,7 +92,7 @@ it("should forward the proper value when using a textArea parameter", () => {
   expect(handleBasicFormParamChange.mock.calls[0][0]).toEqual({
     path: "configuration",
     type: "string",
-    value: "First line\n" + "Second line",
+    value: "First line\nSecond line",
   });
   expect(handler.mock.calls[0][0]).toMatchObject(event);
 });

dashboard/src/components/Header/ContextSelector.tsx

@@ -47,7 +47,7 @@ function ContextSelector({
     if (namespaceSelected !== definedNamespaces.all) {
       getNamespace(clusters.currentCluster, namespaceSelected);
     }
-  }, [fetchNamespaces, namespaceSelected, getNamespace]);
+  }, [fetchNamespaces, namespaceSelected, getNamespace, clusters.currentCluster]);
 
   const toggleOpen = () => setOpen(!open);
   const selectCluster = (event: React.ChangeEvent<HTMLSelectElement>) =>

dashboard/src/components/LoginForm/LoginForm.v2.tsx

@@ -31,7 +31,7 @@ function LoginForm(props: ILoginFormProps) {
     if (oauthLoginURI) {
       checkCookieAuthentication(props.cluster);
     }
-  }, [oauthLoginURI, checkCookieAuthentication]);
+  }, [oauthLoginURI, checkCookieAuthentication, props.cluster]);
 
   if (props.authenticating) {
     return <LoadingWrapper />;