Allow slider render for integer/numeric types (#1796)

Feature implemented + Tests + Docs
vmware-tanzu · Jun 16, 2020 · 8005574 · 8005574
1 parent 007f57c
commit 8005574
Show file tree

Hide file tree

Showing 7 changed files with 1,055 additions and 119 deletions.
diff --git a/dashboard/src/components/DeploymentFormBody/BasicDeploymentForm/BasicDeploymentForm.test.tsx b/dashboard/src/components/DeploymentFormBody/BasicDeploymentForm/BasicDeploymentForm.test.tsx
@@ -50,6 +50,28 @@ const defaultProps = {
       } as IBasicFormParam,
     ],
   },
+  {
+    description: "renders a basic deployment with a integer disk size",
+    params: [
+      {
+        path: "size",
+        value: 10,
+        type: "integer",
+        render: "slider",
+      } as IBasicFormParam,
+    ],
+  },
+  {
+    description: "renders a basic deployment with a number disk size",
+    params: [
+      {
+        path: "size",
+        value: 10.0,
+        type: "number",
+        render: "slider",
+      } as IBasicFormParam,
+    ],
+  },
   {
     description: "renders a basic deployment with username, password, email and a generic string",
     params: [

diff --git a/dashboard/src/components/DeploymentFormBody/BasicDeploymentForm/BasicDeploymentForm.tsx b/dashboard/src/components/DeploymentFormBody/BasicDeploymentForm/BasicDeploymentForm.tsx
@@ -114,7 +114,9 @@ class BasicDeploymentForm extends React.Component<IBasicDeploymentFormProps> {
         );
         break;
       }
-      case "string": {
+      case "string":
+      case "integer":
+      case "number": {
         if (param.render === "slider") {
           const p = param as IBasicFormSliderParam;
           paramComponent = (