Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: edition of an apprepository filter clears it #3447

Closed
dud225 opened this issue Sep 20, 2021 · 1 comment · Fixed by #3931
Closed

front: edition of an apprepository filter clears it #3447

dud225 opened this issue Sep 20, 2021 · 1 comment · Fixed by #3931
Assignees
Labels
component/ui Issue related to kubeapps UI good first issue kind/bug An issue that reports a defect in an existing feature
Projects

Comments

@dud225
Copy link
Contributor

dud225 commented Sep 20, 2021

Description:

When creating a new Application Repository, all works as expected. But when editing it to filter out some charts, there is no error on the UI but the resulting apprepositories filter is reset:

  filterRule:
    jq: ""

Steps to reproduce the issue:

  1. Create an App Repository, e.g. Bitnami
  2. Once the App Repository is creted, edit it to modify the filter, eg nginx, jenkins
  3. Check the resulting apprepositories, the filter will be blank even if one was set up at the time of creation

Version of Helm, Kubeapps and Kubernetes:

  • Output of helm version:
version.BuildInfo{Version:"v3.5.0", GitCommit:"32c22239423b3b4ba6706d450bd044baffdcf9e6", GitTreeState:"clean", GoVersion:"go1.15.6"}
  • Output of helm list -n <kubeapps-namespace> <kubeapps-release-name>:
NAME            NAMESPACE       REVISION        UPDATED                                 STATUS          CHART           APP VERSION
kubeapps        kubeapps        5               2021-09-08 10:10:27.536393583 +0000 UTC deployed        kubeapps-7.4.0  2.4.0
  • Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"21+", GitVersion:"v1.21.4-3+e5758f73ed2a04", GitCommit:"e5758f73ed2a04898a6bba130459e17b95402dcd", GitTreeState:"clean", BuildDate:"2021-08-12T15:05:00Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21+", GitVersion:"v1.21.4-3+e5758f73ed2a04", GitCommit:"e5758f73ed2a04898a6bba130459e17b95402dcd", GitTreeState:"clean", BuildDate:"2021-08-12T15:00:31Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
@project-bot project-bot bot added this to Inbox in Kubeapps Sep 20, 2021
@absoludity
Copy link
Contributor

Thanks @dud225 . Easy to repro. Haven't dug, but from the network request, it looks like the dashboard is simply not setting the filters when updating the app repo. For example, I see the following when setting the filters to "apache,jenkins"
edit-repo-no-filters

Appreciate the help you're giving us lately so reluctant to say patches welcome. We'll prioritise it in our next planning meeting if someone hasn't grabbed it already :)

@absoludity absoludity moved this from Inbox to Next iteration discussion in Kubeapps Sep 21, 2021
@absoludity absoludity added component/ui Issue related to kubeapps UI kind/bug An issue that reports a defect in an existing feature priority/medium labels Sep 21, 2021
@ppbaena ppbaena added this to the App repository refactor milestone Sep 24, 2021
@ppbaena ppbaena moved this from Next iteration discussion to Backlog in Kubeapps Oct 25, 2021
@castelblanque castelblanque self-assigned this Dec 9, 2021
castelblanque pushed a commit that referenced this issue Dec 10, 2021
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
@castelblanque castelblanque moved this from Backlog to Waiting For Review in Kubeapps Dec 10, 2021
Kubeapps automation moved this from Waiting For Review to Done Dec 14, 2021
castelblanque added a commit that referenced this issue Dec 14, 2021
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Issue related to kubeapps UI good first issue kind/bug An issue that reports a defect in an existing feature
Projects
No open projects
Kubeapps
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants