-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Helm values not correctly reported #3621
Comments
Hi Hervé, thanks for reporting it. I'll have a look using the current version in the main branch (as we performed some changes in the AppUpgrade view). However, it could be an actual issue derived from the parsing from yaml <-> json, so it is worth checking. |
Confirming it's an issue we can reproduce. I guess it is something wrong with the parser at one of the ends. Thanks again for letting us know :) The problematic snippet should be either: a) Using curly braces BUT with quoted values. annotations:
{
kubernetes.io/ingress.class: nginx,
nginx.ingress.kubernetes.io/auth-response-headers: "Authorization",
nginx.ingress.kubernetes.io/auth-signin: "https://$host/aaa/start?rd=$escaped_request_uri",
nginx.ingress.kubernetes.io/auth-url: "http://aaa-proxy.kube-system.svc.cluster.local/oauth2/auth",
nginx.ingress.kubernetes.io/configuration-snippet: "rewrite ^(/aaa)$ $1/ redirect;",
nginx.ingress.kubernetes.io/rewrite-target: "/$upstream_path"
} or b) not using curly braces at all annotations:
kubernetes.io/ingress.class: nginx,
nginx.ingress.kubernetes.io/auth-response-headers: Authorization,
nginx.ingress.kubernetes.io/auth-signin: https://$host/aaa/start?rd=$escaped_request_uri,
nginx.ingress.kubernetes.io/auth-url: http://aaa-proxy.kube-system.svc.cluster.local/oauth2/auth,
nginx.ingress.kubernetes.io/configuration-snippet: rewrite ^(/aaa)$ $1/ redirect;,
nginx.ingress.kubernetes.io/rewrite-target: /$upstream_path I'd say the issue is around https://github.com/kubeapps/kubeapps/blob/master/dashboard/src/components/UpgradeForm/UpgradeForm.tsx#L107, but I don't have the bandwidth to closely look at it at the moment. After looking into it a little bit, I'd say it is caused by the usage of two different YAML parsers in the frontend: js-yaml and yaml, so there could be some little differences in the implementation leading to this error. An ugly and quick hotfix is replacing: with: return values.replaceAll("{", "")?.replaceAll("}", ""); If anyone is interested in giving it a try, I'm happy to walk them through it. |
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
* Wrong Helm values reported on Update form (#3621) Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Prettified code (#3621) Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Test fixes for double quotes on modified Helm chart values (#3621) Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Prettified strings on tests (#3621) Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Removed unnecessary scaping (#3621) Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Reopening issue as stated here by a user. |
User confirmed that after upgrade to package version 7.8.10 the issue is gone. |
Hello
I've initially deployed Kubeapps with a long Helm command that happened to add some Nginx annotations:
However those settings are not correctly reported within Kubeapps:
which makes it unhappy when deploying:
Manually adjusting the values in the UI allows the deployment to succeed.
The text was updated successfully, but these errors were encountered: