Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpclient library SetClientTLS cleanup + unit tests #4119

Closed
gfichtenholt opened this issue Jan 19, 2022 · 0 comments · Fixed by #4238
Closed

httpclient library SetClientTLS cleanup + unit tests #4119

gfichtenholt opened this issue Jan 19, 2022 · 0 comments · Fixed by #4238
Assignees
@gfichtenholt
Labels
component/apis-server Issue related to kubeapps api-server kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
Kubeapps
Milestone
Pluggable support...

Comments

@gfichtenholt
Copy link
Contributor

gfichtenholt commented Jan 19, 2022 •
edited

Documenting leftover items for flux plugin per Pepe's request so we can prioritize it against other work

This is a (small) leftover item from #3899
I had to enhance some functionality in our httpclient library:
https://github.com/kubeapps/kubeapps/blob/master/pkg/http-client/httpclient.go
to do with adding new ways to use TLS config. It was done in a hurry because I was rushing to get a much larger change merged. Now is a good time to go back and clean up a couple of items:

  1. fix up https://github.com/kubeapps/kubeapps/blob/50d979f26975c54d953e36edffd2fcf2a36a21e8/pkg/http-client/httpclient.go#L138 to fix up the func signature to be cleaner (marked by a TODO comment)
  2. add unit tests for new functionality
@gfichtenholt gfichtenholt self-assigned this Jan 19, 2022
@project-bot project-bot bot added this to Inbox in Kubeapps Jan 19, 2022
@gfichtenholt gfichtenholt added component/apis-server Issue related to kubeapps api-server size/S labels Jan 19, 2022
@gfichtenholt gfichtenholt removed this from Inbox in Kubeapps Jan 19, 2022
@antgamdia antgamdia added this to Inbox in Kubeapps Jan 19, 2022
@ppbaena ppbaena added this to the Pluggable support for Flux v2 milestone Jan 19, 2022
@ppbaena ppbaena moved this from Inbox to Committed in Kubeapps Jan 19, 2022
@ppbaena ppbaena added kind/enhancement An issue that reports an enhancement for an implemented feature priority/high labels Jan 31, 2022
gfichtenholt added a commit to gfichtenholt/kubeapps that referenced this issue Feb 5, 2022
@gfichtenholt
fix for httpclient library SetClientTLS cleanup + unit tests vmware-t…
ff6cf83 
…anzu#4119

plus a couple unrelated unit test clean up items in flux plugin
@gfichtenholt gfichtenholt linked a pull request Feb 5, 2022 that will close this issue
fix for httpclient library SetClientTLS cleanup + unit tests #4119 & finish flux plugin: switch to using flux native data types instead of unstructured #4112 #4238
Merged
Kubeapps automation moved this from Committed to Done Feb 9, 2022
gfichtenholt added a commit that referenced this issue Feb 9, 2022
@gfichtenholt
fix for httpclient library SetClientTLS cleanup + unit tests #4119 & …
02bb375 
…finish flux plugin: switch to using flux native data types instead of unstructured #4112  (#4238)

* attempt #2

* fix for  httpclient library SetClientTLS cleanup + unit tests #4119
plus a couple unrelated unit test clean up items in flux plugin

* remove most files from PR to see if passes CI end-2-end tests

* add files back into PR, as they seem to have no effect on CI

* remaining work for  flux plugin: switch to using flux native data types instead of unstructured #4112 (part 1)

* flux plugin: switch to using flux native data types instead of unstructured #4112 (part 2)

* flux plugin: switch to using flux native data types instead of unstructured #4112 (part 3)

* flux plugin: switch to using flux native data types instead of unstructured #4112 (part 5)

* flux plugin: switch to using flux native data types instead of unstructured #4112 part 5

* minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfichtenholt gfichtenholt

Labels
component/apis-server Issue related to kubeapps api-server kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
No open projects
Kubeapps
  
Done
Milestone
Pluggable support for Flux v2
2 participants
@ppbaena @gfichtenholt