Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a warning message for non semver versions #1038

Merged
merged 3 commits into from May 30, 2019
Merged

Show a warning message for non semver versions #1038

merged 3 commits into from May 30, 2019

Conversation

andresmgot
Copy link
Contributor

Fixes #1036

Screenshot from 2019-05-21 10-31-33

The auto generated name of the app is well... auto generated 馃槀

@andresmgot andresmgot requested a review from prydonius May 21, 2019 18:10
prydonius
prydonius approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm!

dashboard/src/components/AppView/ChartInfo.tsx Outdated Show resolved Hide resolved
andresmgot and others added 2 commits May 30, 2019 10:22
@andresmgot @prydonius
Update dashboard/src/components/AppView/ChartInfo.tsx
5763684 
Co-Authored-By: Adnan Abdulhussein <adnan@prydoni.us>
Fix test
56c62f7
@andresmgot andresmgot merged commit 62db7f6 into vmware-tanzu:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prydonius prydonius prydonius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show a warning for non-semver versions
2 participants
@andresmgot @prydonius