Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set terminal white-space to pre-wrap #1116

Merged
merged 2 commits into from Aug 8, 2019

Conversation

lindhe
Copy link
Contributor

@lindhe lindhe commented Aug 7, 2019

This preserves indentations in the code that is to be displayed.

Signed-off-by: Andreas Lindhé andreas@lindhe.io

This preserves indentations in the code that is to be displayed.

Signed-off-by: Andreas Lindhé <andreas@lindhe.io>
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! Can you send a couple of screenshots with the status before and after?

@lindhe
Copy link
Contributor Author

lindhe commented Aug 8, 2019

Sure! However, right now it's not very easy for me to spin up two different versions of Kubeapps to show the actual before-and-after. These screenshots are doctored using the Firefox development tools, adding the white-space: pre-wrap attribute to the .Terminal__Code class.

So while this ought to be representative, this is not a validation of the actual results.

Before

Screenshot_2019-08-08 Kubeapps Dashboard

After

Screenshot_2019-08-08 Kubeapps New Dashboard

@andresmgot
Copy link
Contributor

Great, thanks!

With regards to your issue, have you checked the dev guide for the dashboard?

https://github.com/kubeapps/kubeapps/blob/master/docs/developer/dashboard.md

That should help you spinning up a dev environment if you want.

@andresmgot andresmgot merged commit 308d105 into vmware-tanzu:master Aug 8, 2019
@lindhe lindhe deleted the lindhe-terminal-wrap branch August 8, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants