Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongodb dependency to support deployment on k8s 1.16 #1176

Merged
merged 3 commits into from Sep 24, 2019

Conversation

absoludity
Copy link
Contributor

While investigating installation on k8s 1.16 for a Sahel [1] I noticed that installing the Kubeapps chart would fail because the mongodb dependency version was using old api endpoints too.

Even though we've recently updated the dep, 2.7.7 still has the removed endpoints for the standalone deployment:

~$ helm fetch --untar stable/mongodb --version 7.2.7 && cd mongodb
~/mongodb$ rg extensions
templates/ingress.yaml
2:apiVersion: extensions/v1beta1

templates/deployment-standalone.yaml
2:apiVersion: extensions/v1beta1

2.7.9 does not:

$ helm fetch --untar stable/mongodb --version 7.2.9 && rg extensions mongodb/                                                                                                                                          
mongodb/README.md
256:The allowed extensions are `.sh`, and `.js`.

mongodb/templates/ingress.yaml
2:apiVersion: extensions/v1beta1
~$ 

[1] https://kubernetes.slack.com/archives/C9D3TSUG4/p1569292968011900

@absoludity absoludity self-assigned this Sep 24, 2019
@absoludity absoludity added this to In progress in Kubeapps via automation Sep 24, 2019
@@ -1,6 +1,6 @@
dependencies:
- name: mongodb
repository: https://kubernetes-charts.storage.googleapis.com
version: 7.2.7
version: 7.2.9
digest: sha256:415440e73af7d4b02a10a15f28bb2fc095cbdffdc2e1676d76e0f0eaa1632d50
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erm, checking why the digest didn't change...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it doesn't change (the commit history shows it not changing) and I see now it's not a digest of the chart dependency.

@andresmgot
Copy link
Contributor

Thanks for fixing the investigation!

@absoludity absoludity merged commit 831c02f into vmware-tanzu:master Sep 24, 2019
Kubeapps automation moved this from In progress to Done Sep 24, 2019
@absoludity absoludity deleted the further-k8s1.16-changes branch September 24, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Kubeapps
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants