Fix currentNamespace #1192
Merged
Fix currentNamespace #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Sep 30, 2019
| @@ -32,7 +32,8 @@ const namespaceReducer = ( | |||
| case getType(actions.namespace.errorNamespaces): | |||
| return { ...state, errorMsg: action.payload.err.message }; | |||
| case getType(actions.namespace.clearNamespaces): | |||
| return { ...initialState }; | |||
| // Clear namespaces info but keep "current" to avoid unexpected redirections | |||
| return { ...initialState, current: state.current }; | |||
There was a problem hiding this comment.
After login out the current namespace was cleared to the default value (default). This caused that after login out and in again the namespace changed from whatever it was to default.
Isn't that the expected behaviour - that if I log out there is no state, so that when I log back in, I'll be put on the default namespace? I'm not sure what I'm missing on this one, but +1'ing so we can start those release images :)
There was a problem hiding this comment.
not really, the state is better cleaned up when reloading the page.
Let me put an example of the issue.
- I got my token for the namespace
user-1. I login in Kubeapps with that token and go to to my namespace. - I go to the
/catalogpage, which doesn't have the namespace in the route. - I click on "logout" and the current namespace is set back to
default. - I login again, and since I haven't changed the namespace in the selector I got again in the
/catalogpage but this time, the selected namespace isdefault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a couple of issues while doing some QA:
namespaceinRoutes.tsxis always defined (and is pointing todefaultsince the token has not been read yet). So, regardless of the content of the token once logged in, it was redirecting me to thedefaultnamespace. To avoid that I have added the additional check to only redirect to/apps/ns/{ns}when accessing the root path (/) if the user is already authenticated.currentnamespace was cleared to the default value (default). This caused that after login out and in again the namespace changed from whatever it was todefault. To avoid this, we should not remove thecurrentnamespace from the state.