Check repo state instead of props when upgrading #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Jan 20, 2020
| @@ -93,7 +94,7 @@ class AppUpgrade extends React.Component<IAppUpgradeProps, IAppUpgradeState> { | |||
| repo && | |||
| repo.metadata && | |||
| repo.metadata.name && | |||
| (prevProps.app !== app || prevProps.repo !== repo) | |||
| (prevProps.app !== app || prevRepo !== repo) | |||
There was a problem hiding this comment.
I had expected the test you added with 7b96684 to fail with this change, as it was added to verify that if the props.repo changes it fetches the data? Why is it not failing?
There was a problem hiding this comment.
In that test, state.repo is empty at the beginning. Then component gets updated with props.repo. componentDidUpdate is executed and the state is updated. Since prevRepo was empty and repo now contains the repo info, getDeployedChartVersion is executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
After #1455 I introduced a regression. When upgrading, if the repository can be auto-resolved, the properties of
AppUpgradeare not being updated and the condition I introduced was alwaystrue, causing an infinity loop.