-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redux namespace(s) state to clusters state. #1804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -55,7 +55,7 @@ class Header extends React.Component<IHeaderProps, IHeaderState> { | |||
public render() { | |||
const { | |||
fetchNamespaces, | |||
namespace, | |||
cluster: cluster, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this a lint issue? I would say that it forces this to be cluster,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strangely not, it seems. Updated.
import { IResource } from "../shared/types"; | ||
import clusterReducer, { IClustersState } from "./cluster"; | ||
|
||
describe("namespaceReducer", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clusterReducer
f42d9d6
to
1dce11e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if I have to re-review something
1dce11e
to
1ab6f1a
Compare
The main change here is just:
Note that
IClusterState
(singular) is almost identical to whatINamespaceState
was (just s/current/currentNamespace). This change allows us to store the state of each cluster separately (including the current namespace which the user was using). The rest of the changes are just refactoring to the new format.Ref: #1762