Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test chart upgrade #1807

Merged
merged 5 commits into from
Jun 19, 2020
Merged

Test chart upgrade #1807

merged 5 commits into from
Jun 19, 2020

Conversation

andresmgot
Copy link
Contributor

Description of the change

The goal of this PR is to add a basic test to ensure we don't break the upgrade process (at least with the flags we use in our CI system). To avoid having another build or run the upgrade test for every build I am adding the env var TEST_UPGRADE to the PostgreSQL + Helm 3 scenario (the "recommended" setup).

The test is just installing the kubeapps chart from the bitnami repository and upgrading it afterwards with the status of the current chart folder.

Benefits

Breaking changes in the chart will be noticed.

Applicable issues

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution Andres. +1 for only testing with the recommended setup for now - we can't test all combinations (and the sooner we get the combinations down, the better), but one thing this won't allow is testing a mongodb install upgrading to pg, for example?

@andresmgot
Copy link
Contributor Author

andresmgot commented Jun 19, 2020

Nice solution Andres. +1 for only testing with the recommended setup for now - we can't test all combinations (and the sooner we get the combinations down, the better), but one thing this won't allow is testing a mongodb install upgrading to pg, for example?

yes, we are not covering that use case (which is a corner case anyway). When doing "weird" changes to the default values we need to handle them carefully anyway.

@andresmgot andresmgot merged commit 474374e into master Jun 19, 2020
@andresmgot andresmgot deleted the testUpgrade branch September 8, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI should test chart upgrades
2 participants