-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout v2 component #1821
Layout v2 component #1821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments. I think it'd be worth waiting for the package updates so we no longer need to wrap components in containers to access state.
}; | ||
} | ||
|
||
export default connect(mapStateToProps)(Layout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: you might to wait or my branch updating our redux/react-router dependencies etc. as you'll no longer need a container to access state (as it can be accessed via hooks). Similarly, updating connected-react-router forces adding the router state to the IStoreState
as you've done manually here (ie. it'll already be done in my branch).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to merge this before so I don't have conflicts since it's quite simple, in any case, the route thing is not needed.
Description of the change
The
Layout
is the first self-written component that we render. I am following the same approach than in #1814 to conditionally load one file or another depending on the UI in the configuration. Note that the requisites to do this are:Layout
component..v2
) should be loaded for the Clarity UI.Result:
With the
hex
UI:With the
clarity
UI:Note that the Layout component is just a wrapper, we still need to work in all the components of the different views.
Applicable issues
Additional information
The change of base branch messed a bit the git history but I've also moved the
UISelector
to the layout component, I believe there is a better place rather than in theHeader
component.