Small adjustments to #1823 #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
commented
Jun 26, 2020
| @@ -13,7 +13,7 @@ describe("Config", () => { | |||
|
|
|||
| defaultJSON = require("../../public/config.json"); | |||
|
|
|||
| moxios.stubRequest("config.json", { status: 200, response: defaultJSON }); | |||
| moxios.stubRequest("config.json", { status: 200, response: { ...defaultJSON } }); | |||
There was a problem hiding this comment.
This was the reason it was passing either way - the actual defaultJSON data was being updated by the code, rather than a copy of the data. Perhaps the require only happens once - I'm not sure, but the test now fails if you comment out line 36 below (where as it didn't when you removed it due to TS complaining about a read-only value).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of small changes I wanted to check from #1823.