Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Header v2 compilation #1841

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Fix Header v2 compilation #1841

merged 1 commit into from
Jul 1, 2020

Conversation

andresmgot
Copy link
Contributor

Description of the change

Fix build in master

absoludity
absoludity approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have landed before you approved and landed the build changes?

@absoludity absoludity merged commit 35b8950 into master Jul 1, 2020
@andresmgot
Copy link
Contributor Author

Thanks for merging it.

This must have landed before you approved and landed the build changes?

I am not sure what you mean? Yes, this should've been done before merging the change in the Header.v2 component the problem is that we created the "conflicting" PRs at the same time (and I didn't notice).

@andresmgot andresmgot deleted the fixHeaderv2 branch September 8, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absoludity absoludity absoludity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andresmgot @absoludity