Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#1855 #1884

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Fix/#1855 #1884

merged 2 commits into from
Jul 22, 2020

Conversation

ralphsmith80
Copy link
Contributor

This fix adds missing post body parameter to ServiceBinding:create. These parameters are required.

I didn't use a close commit for this because while this does solve the problem of creating a binding I'm still seeing a 404 error fetching the secret after the binding is created. I will look at that further but I would like to keep the commits focused and small.

The second commit in this PR is an update to the developer documentation that provide an alternative to Telepresence for running the dashboard locally. I needed to do that myself since I could not get past the Mac SIP issue with Telepresence without disabling it entirely which I did not want to do.

As noted above I don't want to but fixes because it solves some of the issues with Binding but I'm not sure yet if it solves all the problems.

@ralphsmith80
Copy link
Contributor Author

Looks like I can't manually link the issue either so I'll say relates to #1855 .

@ralphsmith80
Copy link
Contributor Author

I was on the fence if the fetch for the binding secret was on my broker so I ran through this with the minibroker and an instance of the mariadb. While the initial fetch for the secret failed after refreshing the page it worked as expected. So I think we can close #1855 .

The 404 issue is an issue not properly waiting or handling the async behavior of k8s creating the secret after the binding is created.

Initial binding creation

Binding-Created

binding-secret-fail-response

binding-secret-fails

After page refresh

binding-secret-success-response

binding-secret

Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improved docs too..

@absoludity absoludity merged commit 66ce3c8 into vmware-tanzu:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants