Disable host check for dev setup #1891
Conversation
There was a problem hiding this comment.
After #1884, the expected host is
127.0.0.1when running the server locally, this breaks my local dev environment because I am usingkubeapps.local. Disabling the host check since we don't need it for the dev setup.
I don't think we should be setting the DANGEROUSLY_DISABLE_HOST_CHECK=true - it's dangerous for a reason and using this by default can have unexpected consequences for people developing.
Have you tried what's recommended in the docs with specifying your public host in the the .env.development file? If that doesn't work, I'd update #1884 to include the proxy as a comment and update the docs accordingly (they already mention the setting, just mention that it can be uncommented), rather than using this setting.
It didn't work, I assume because we are accessing the service through telepresence. I had to remove the setting from the package.json. |
docs/developer/dashboard.md
Outdated
| + "proxy": "http://127.0.0.1:8080" | ||
| ``` | ||
|
|
||
| > **NOTE**: The [proxy](../../dashboard/package.json#L176) `key:value` has already added to the `package.json` for convenience but you can change the `host:port` values to meet your needs. |
There was a problem hiding this comment.
This note is no longer correct, I think?
There was a problem hiding this comment.
right, forgot to update the comment
Description of the change
After #1884, the expected host is
127.0.0.1when running the server locally, this breaks my local dev environment because I am usingkubeapps.local. Disabling the host check since we don't need it for the dev setup.