Update oauth2-proxy from 5.x to 6.x #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only breaking change is that flags now require -- . For details of breaking changes in 6.x: https://github.com/oauth2-proxy/oauth2-proxy/blob/master/CHANGELOG.md#breaking-changes-1
andresmgot
approved these changes
Jul 30, 2020
| @@ -646,7 +646,7 @@ authProxy: | |||
| image: | |||
| registry: docker.io | |||
| repository: bitnami/oauth2-proxy | |||
| tag: 5.1.1-debian-10-r58 | |||
| tag: 6.0.0-debian-10-r23 | |||
| ## Specify a imagePullPolicy | |||
| ## ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images | |||
| ## | |||
There was a problem hiding this comment.
the comments in lines 671-674 need to be updated as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The only breaking change is that flags now require -- .
For details of breaking changes in 6.x:
https://github.com/oauth2-proxy/oauth2-proxy/blob/master/CHANGELOG.md#breaking-changes-1
Benefits
Using more secure latest oauth2-proxy (project migrated earlier this year).
Possible drawbacks
Users who have set
.Values.authProxy.additionalFlagswill need to update those (auth-proxy container will refuse to start).