Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use go mod and remove vendors #2116

Merged
merged 2 commits into from
Oct 20, 2020
Merged

use go mod and remove vendors #2116

merged 2 commits into from
Oct 20, 2020

Conversation

qianlei90
Copy link
Contributor

@qianlei90 qianlei90 commented Oct 16, 2020 •
edited

Description of the change

  • This PR just update go mod and remove vendors: rm -rf vendor/ && go mod tidy
  • make test passed

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

@andresmgot
Copy link
Contributor

Thanks for the PR @qianlei90, actually since we are using go mod, we should be able to remove the vendor/ folder and avoid huge PRs like this one. Can you give it a try?

@qianlei90
Copy link
Contributor Author

done. PTAL.

@andresmgot
Copy link
Contributor

You will need to remove lines like this one: https://github.com/kubeapps/kubeapps/blob/master/cmd/kubeops/Dockerfile#L6 for the different services

@qianlei90 qianlei90 changed the title update vendors [WIP] update vendors Oct 19, 2020
@qianlei90 qianlei90 changed the title [WIP] update vendors [WIP] use go mod and remove vendors Oct 19, 2020
andresmgot
andresmgot approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@andresmgot andresmgot merged commit 3b66223 into vmware-tanzu:master Oct 20, 2020
@qianlei90 qianlei90 changed the title [WIP] use go mod and remove vendors use go mod and remove vendors Oct 21, 2020
@qianlei90 qianlei90 deleted the update_vendor branch October 21, 2020 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qianlei90 @andresmgot