Fix resource table when working with lists #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Oct 23, 2020
| ), | ||
| resources.map((resource, index) => { | ||
| // When the resourceRef is a list, the list of references will be just one | ||
| const ref = resourceRefs[index] || resourceRefs[0]; |
There was a problem hiding this comment.
This looks a little ambiguous to me, in that if there were 3 resource refs and 5 resources it would get the refs for the first 3 iterations and then the 0th for the fourth and fifth (not that that's possible for the data you expect). If you expect that the length of resourceRefs will be 1 specifically in this case, why not make that explicit:
const ref = (resourceRefs.length === 1) ? resourceRefs[0] : resourceRefs[index];
so that if our expectations aren't met, we'll still get an error as we should, rather than masking it with odd behaviour?
There was a problem hiding this comment.
Got it, yes, it's also more readable that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
At the moment, the code was assuming that there were one resource reference per resource in the state. Sometimes the reference points to a list so there will be more resources than references.
This PR also handles the case in which there are no references at all (but this is not happening IRL).
Applicable issues