Add search (crtl+F) in ACE editors #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crtl+F will now trigger a searchbox to appear.
andresmgot
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
ACE text editors have lots of features out-of-the-box ready to be used. For instance, the keybind Crtl+F should trigger a search box for searching within the text. However, this feature was not enabled. This PR is to support that.
Benefits
Crtl+F will now trigger a searchbox to appear.
Possible drawbacks
N/A
Applicable issues
N/A
Additional information
See the full list of ACE modules here: https://github.com/ajaxorg/ace-builds/blob/master/ace-modules.d.ts