Change ordering in some arguments to "cluster, namespace, other args" #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"cluster, others, namespace" and "cluster, namespace, others" orderings were mixed up across the code. Change tests accordingly.
antgamdia
added a commit
to antgamdia/kubeapps
that referenced
this pull request
Nov 5, 2020
andresmgot
approved these changes
Nov 5, 2020
antgamdia
added a commit
that referenced
this pull request
Nov 9, 2020
) * Add a new API endpoint to force a refresh in a appRepository Rel #2062 For instance, "POST /api/v1/clusters/default/namespaces/kubeapps/apprepositories/bitnami/refresh" will trigger a refresh in the "bitnami" appRepository in the namespace "kubeapps" * Change endpoint of appRepository refresh button Rel #2062 Now it calls the new POST .../refresh endpoint implemented in the backend. * Change ordering in some arguments to "cluster, namespace, other args" Rel #2147 * Remove unnecessary namespace check * Revert unnecessary change Also fix minor typo * Remove unnecessary test step Since refreshing an apprepository no longer requires to get the repo to send an edition later, this test step (faulty) can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
cluster, others, namespaceandcluster, namespace, othersorderings were mixed up across the code. This PR review each file using these methods and changes the order properly. Tests changed accordingly.Benefits
Now the two first arguments will be
cluster, namespace. It was quite odd to be constantly mixing these two orderings and may lead to accidental errors due to a parameter misteaching (note normally they are both string so no type alert will be thrown).Possible drawbacks
Despite the best effort applied in looking up each method usage, it is slightly possible to have missed some reference.
Applicable issues
Additional information
N/A