Allow to bypass the oauth loading page #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Nov 9, 2020
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v1 | |||
| name: kubeapps | |||
| version: 4.0.4 | |||
| version: 4.0.5 | |||
There was a problem hiding this comment.
Maybe land this after @antgamdia 's PR with the ClusterRole, so they're both included in the chart update (once you've reviewed his).
There was a problem hiding this comment.
well, @antgamdia changes cannot be used until the new endpoint (/refresh) is available so the change in the chart is not going to be usable yet.
| } else { | ||
| dispatch(setAuthenticated(false, false, "")); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Perhaps just
return isAuthed;
instead?
| mount(<LoginForm {...defaultProps} checkCookieAuthentication={checkCookieAuthentication} />); | ||
| expect(checkCookieAuthentication).not.toHaveBeenCalled(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Because this was already been covered in the tests under "oauth login form" (sorry I forgot to mention that).
added 2 commits
November 9, 2020 10:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
As per #2109, allow users to configure Kubeapps so it skips the login/welcome page and redirect directly to the OAuth login URI.
To use it, a value is exposed in the chart:
--set authProxy.skipKubeappsLoginPage=true.Applicable issues