Add apprepositories-webhook ClusterRole in kupeapps chart #2151
Conversation
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: "kubeapps:{{ .Release.Namespace }}:apprepositories-webhook" |
There was a problem hiding this comment.
I'd call this kubeapps:{{ .Release.Namespace }}:apprepositories-refresh to follow the same naming than the others.
There was a problem hiding this comment.
Good idea. Since it involves changing the docs, I will also send a PR for that purpose.
EDIT: See #2153
|
I've just noticed that this PR was closed but not merged (I initially configured it as a draft, so it couldn't be merged). |
| metadata: | ||
| name: "kubeapps:{{ .Release.Namespace }}:apprepositories-refresh" | ||
| labels:{{ include "kubeapps.extraAppLabels" . | nindent 4 }} | ||
| app: {{ template "kubeapps.apprepository.fullname" . }} |
There was a problem hiding this comment.
We missed the indentation here - app: is a label, not a field on metadata - which caused CI to fail, but we currently have false positives so it makes a genuine failure easier to ignore. We should fix that :) Anyway, I've fixed it as part of #2162 .
There was a problem hiding this comment.
My bad! I didn't notice it! Thanks for pointing out and fix it!!!
Description of the change
After the discussion in PR #2150. A ClusterRole can be added by default during the Kubeapps installation via Helm.
Benefits
We henceforth will have an
apprepositories-webhookClusterRole and users just have to create a ServiceAccount and a RoleBinding to start using the webhook endpoint.Possible drawbacks
I'm not aware right now of the consequences of changing the chart here. Perhaps there are some requirements. For now, I'm sending this PR as a draft.
Applicable issues
Additional information
N/A